Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Include metadata with Assistant say util #2300

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

misscoded
Copy link
Contributor

Summary

Introduces behavior seen in Python and Java implementations, where thread context is appended as metadata to messages posted with say utility provided within the Assistant class. See discussion for details.

Requirements (place an x in each [ ])

@misscoded misscoded added the enhancement M-T: A feature request for new functionality label Oct 24, 2024
@misscoded misscoded requested review from seratch and filmaj October 24, 2024 00:40
@misscoded misscoded self-assigned this Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (198d7c3) to head (e85abb9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2300   +/-   ##
=======================================
  Coverage   92.47%   92.48%           
=======================================
  Files          36       36           
  Lines        7457     7466    +9     
  Branches      648      651    +3     
=======================================
+ Hits         6896     6905    +9     
  Misses        553      553           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Assistant.ts Outdated Show resolved Hide resolved
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM; let a minor suggestion on the test code

test/unit/Assistant.spec.ts Show resolved Hide resolved
@misscoded misscoded merged commit b671add into main Oct 25, 2024
18 checks passed
@misscoded misscoded deleted the assistant-say-metadata branch October 25, 2024 21:23
@filmaj filmaj added this to the 4.1 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants